[chuck-dev] miniaudicle patch to conpile on recent linux

[Spencer Salazar]

Hey Ricardo,

Thanks for the patches. Examining these cursorily, these look pretty
solid (both chuck and mini patches). I will integrate + build/test
next time I have a chance to boot up Linux.

You could either recreate the first patch with the intptr_t change, so
that everything is a single patch, or send a second patch that assumes
the first patch has already been applied -- either way seems
reasonable. I think there are few enough changes here that I can
cherry-pick and/or manually apply changes if that is necessary for
some reason.

spencer

On Thu, Oct 20, 2011 at 1:01 PM, Ricardo Fabbri <rfabbri at gmail.com> wrote:
> Hi,
>
> I discovered that some of the void * to (long) casts, with the
> implicit truncation to an "int", in the patch I sent are
> better and more portably done using intptr_t instead of long. Moreover
> one should try to use reinterpret_cast in these cases.
>
> Note that this is also an important aspect for getting the code to
> work in 64bits.
>
> I could make the aforementioned changes for you, however I am not sure
> what to do when there is patch on top of pending patches. Let me know the best
> way to contribuite in these cases.
>
> Thanks,
> Fabbri
>
>
> On Wed, Oct 19, 2011 at 11:20 PM, Ricardo Fabbri <rfabbri at gmail.com> wrote:
>> Hi,
>>
>> I wrote a patch to get miniaudicle svn to compile on some recent linux setups.
>> I can now compile miniaudicle on Ubuntu 11.10. I tested it with
>>
>> Gcc 4.6.1
>> wxwidgets 2.8
>> chuck from svn
>>
>> The patch has further comments. I hope it is useful to you and not
>> just a bunch of hacks.
>> Let me know if you want me to break it apart into even smaller
>> patches. I feel like sometimes it can be a hassle to receive tiny
>> patches one after the other. The way I've done it I guess you can
>> reasonably cherry-pick what will make into the official repo.
>>
>> PS: this patch is dedicated to mighty greenkobold, it's his birthday today!!!
>>
>> Fabbri
>>
> _______________________________________________
> chuck-dev mailing list
> chuck-dev at lists.cs.princeton.edu
> https://lists.cs.princeton.edu/mailman/listinfo/chuck-dev
>