[chuck-dev] miniaudicle patch to conpile on recent linux

[Ricardo Fabbri]

Hi, Spencer,

thanks for the reply.

I am attaching a patch with intptr_t instead of long where
conversions to/from void * take place. This patch is incremental - it
assumes the
previous one I sent has been applied. However, as you said, the changes are
simple enough that you can cherypick directly if you want.

I have decided to use C++ - style casting (reinterpret_cast and
static_cast) in these cases where pointer <-> int conversions are
happening, the only reason being that this style is clearer and I find
it useful for these cases. However, if you prefer C-style casting for
its brevity, that should also work just fine.

Best,
Fabbri



On Thu, Oct 20, 2011 at 6:15 PM, Spencer Salazar
<spencer at ccrma.stanford.edu> wrote:
> Hey Ricardo,
>
> Thanks for the patches. Examining these cursorily, these look pretty
> solid (both chuck and mini patches). I will integrate + build/test
> next time I have a chance to boot up Linux.
>
> You could either recreate the first patch with the intptr_t change, so
> that everything is a single patch, or send a second patch that assumes
> the first patch has already been applied -- either way seems
> reasonable. I think there are few enough changes here that I can
> cherry-pick and/or manually apply changes if that is necessary for
> some reason.
>
> spencer
>
> On Thu, Oct 20, 2011 at 1:01 PM, Ricardo Fabbri <rfabbri at gmail.com> wrote:
>> Hi,
>>
>> I discovered that some of the void * to (long) casts, with the
>> implicit truncation to an "int", in the patch I sent are
>> better and more portably done using intptr_t instead of long. Moreover
>> one should try to use reinterpret_cast in these cases.
>>
>> Note that this is also an important aspect for getting the code to
>> work in 64bits.
>>
>> I could make the aforementioned changes for you, however I am not sure
>> what to do when there is patch on top of pending patches. Let me know the best
>> way to contribuite in these cases.
>>
>> Thanks,
>> Fabbri
>>
>>
>> On Wed, Oct 19, 2011 at 11:20 PM, Ricardo Fabbri <rfabbri at gmail.com> wrote:
>>> Hi,
>>>
>>> I wrote a patch to get miniaudicle svn to compile on some recent linux setups.
>>> I can now compile miniaudicle on Ubuntu 11.10. I tested it with
>>>
>>> Gcc 4.6.1
>>> wxwidgets 2.8
>>> chuck from svn
>>>
>>> The patch has further comments. I hope it is useful to you and not
>>> just a bunch of hacks.
>>> Let me know if you want me to break it apart into even smaller
>>> patches. I feel like sometimes it can be a hassle to receive tiny
>>> patches one after the other. The way I've done it I guess you can
>>> reasonably cherry-pick what will make into the official repo.
>>>
>>> PS: this patch is dedicated to mighty greenkobold, it's his birthday today!!!
>>>
>>> Fabbri
>>>
>> _______________________________________________
>> chuck-dev mailing list
>> chuck-dev at lists.cs.princeton.edu
>> https://lists.cs.princeton.edu/mailman/listinfo/chuck-dev
>>
> _______________________________________________
> chuck-dev mailing list
> chuck-dev at lists.cs.princeton.edu
> https://lists.cs.princeton.edu/mailman/listinfo/chuck-dev
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rfabbri-intptr_t-20111020.patch
Type: text/x-patch
Size: 5760 bytes
Desc: not available
URL: <http://lists.cs.princeton.edu/pipermail/chuck-dev/attachments/20111020/a5c57400/attachment-0001.bin>